Send real player entity id, implement EntityResurrectEvent, fix #1049

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition

https://glowstone.net

Other

1.88k stars 269 forks source link

Send real player entity id, implement EntityResurrectEvent, fix #1049 #1050

Closed SHADOWDANCH closed 4 years ago

SHADOWDANCH commented 4 years ago

This pull request do such changes:

Now server will send real entity id to player that join server instead 0, like it is works in official mojang server.
For storing living entity potion effects now uses ConcurrentHashMap instead HashMap. Fixes #1049.
Implemented firing of EntityResurrectEvent and reworked "Totem of Undying" logic to work more like in vanilla.

P.S: my english is not best :D. Feel free to say in comments if i spell something wrong.

CLAassistant commented 4 years ago

All committers have signed the CLA.

Paulomart commented 4 years ago

I would suggest splitting this PR into three separate ones. But that would be up the maintainers.

mastercoms commented 4 years ago

They're small enough for me not to mind this time.

SHADOWDANCH commented 4 years ago

I would suggest splitting this PR into three separate ones. But that would be up the maintainers.

I think about it too but for me this changes separated looks very small for pr.

mastercoms commented 4 years ago

I think about it too but for me this changes separated looks very small for pr.

The changes might be small. But, what if we approve one of your changes, but not the other? Then the whole PR is stalled for longer than it needs to be.

mastercoms commented 4 years ago

Thank you for your contribution to Glowstone!