search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.89k stars 272 forks source link

[WIP] Ran a Node script to remove the damage property from the recipes.yml.… #1073

Closed birbe closed 4 years ago

birbe commented 4 years ago

Removed the damage property from the recipes with a Node script. This also makes it easier to deal with as in many places we no longer return a map that includes a material along with its damage but simply the material namespaced key alone.

Someone still needs to remove the non-existent blocks from the recipes.

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

birbe commented 4 years ago

Building has failed as I haven't updated code to suit the new format.

birbe commented 4 years ago

This also gets rid of the amount specifier. I wouldn't change the format and instead just remove the damage IDs.

My bad. Will fix.

birbe commented 4 years ago

I've updated the result.

birbe commented 4 years ago

The YML parser seemed to have messed up re-serializing some of the arrays and they are now just keyed maps, am fixing.

mastercoms commented 4 years ago

@Birbe could you possibly send us the Node script under a compatible license for us to continue this work?

birbe commented 4 years ago

I probably won't be able to find it; I might be able to rewrite it though.

mastercoms commented 4 years ago

Ok, if you could do that, it would be most helpful. Thank you!

birbe commented 3 years ago

Oof, really sorry to leave you hanging like this. I got the script; I'm cleaning up my computer and I found it, not sure if it's still relevant. rx2j.zip

As for the license:

I donate the attached files and code as a part of the GlowstoneMC project, you may use it however you'd like.

mastercoms commented 3 years ago

Thanks so much!