BlockData implementation

[mosemister]

This is my first PR for any public project so sorry if the format isn't correct.

This PR is to solve the issue of https://github.com/GlowstoneMC/1.13-board/issues/28 As this is my first issue any and all comments will be appciated to make the code more to the Glowstone standard.

Implementations currently done:

• [x] NoteBlock
• [X] Anvil
• [X] Bed
• [X] Beetroot
• [X] EnderRod
• [x] BrewingStand
• [x] BubbleColumn
• [x] Cactus
• [x] Cake
• [x] Carrots
• [x] Cauldron
• [x] Chest
• [x] ChorusFlower
• [x] ChorusFruit
• [x] CobblestoneWall
• [x] Cocoa
• [x] Command
• [x] Comparator
• [x] Conduit
• [x] CoralDead
• [x] CoralFan
• [x] CoralFanWall
• [x] CoralPlant
• [x] DaylightDetector
• [x] Detector Rail
• [x] DirtSnow
• [x] Dispenser
• [x] Door
• [x] Dropper
• [x] EnderChest
• [x] EnderPortalFrame
• [x] Fence
• [x] FenceGate
• [x] Fire
• [x] FloorSign
• [x] Fluid
• [x] Frosted Ice
• [x] Furnace (original)
• [x] GlazedTerracotta
• [x] Grass
• [x] Hay
• [x] Hopper
• [x] HugeMushroom
• [x] IronBars
• [x] Jack-O-lantern
• [x] JukeBox
• [x] Kelp
• [x] Ladder
• [x] Leaves
• [x] Lever
• [x] Log
• [x] MinecartDetector
• [x] MinecartTrack
• [x] Mycel
• [x] NetherWart
• [x] Observer
• [x] Piston
• [x] PistonExtension
• [x] PistonMoving
• [x] PlayerSkull
• [x] Portal
• [x] Potatoes
• [x] PowerRails
• [x] PressurePlate Binary
• [x] PressurePlateWeighted
• [x] RedstoneLamp
• [x] RedstoneOre
• [x] RedstoneRepeater
• [x] RedstoneTorchStanding
• [x] RedstoneTorchWall
• [x] RedstoneWire
• [x] Reeds
• [x] Sapling
• [x] SeaPickle
• [x] ShulkerBlock
• [x] Skull
• [x] Snow
• [x] Soil
• [x] StainedGlassPane
• [x] Stairs
• [x] StandingBanner
• [x] Stem
• [x] StoneButton
• [x] Structure
• [x] TNT
• [x] TallPlantFlower
• [x] TallSeaGrass
• [x] TrapDoor
• [x] TrappedChest
• [x] Tripwire
• [x] TripwireHook
• [x] TurtleEgg
• [x] Vine
• [x] WallBanner
• [x] WallPlayerSkull
• [x] WallSign
• [x] WallTorch
• [x] WallWitherSkull
• [x] WitherSkull
• [x] WoodenButton

[claassistantio]

All committers have signed the CLA.

[mastercoms]

Hi, welcome to Glowstone! I really appreciate your initiative on this issue. One thing I would like to point out is that statically typed properties like this will prove to be cumbersome when initializing block data from IDs, unless we were to create class specific initializing for every material, or used slow reflection to product block data. Neither approach is preferable, so I'd recommend taking a different approach to tackle this problem. Admittedly, this issue is one of our most difficult, as signified by the high bounty. If this is your first PR, I would recommend tackling one of the smaller issues first, and communicating with us on our Discord to get help on how to get your way around Glowstone!

[smartboyathome]

To add to what @mastercoms said, this solution does not provide a mechanism for translating blockdata to the appropriate over-the-network ID, which is stored in the generated block report (see the linked issue on 1.13-board). Your solution will need to take this into account for that.

[mosemister]

Thats fair. I am very familiar with Sponge API that uses Key Value pairing for this and I know the glowstone project doesn't want anything based off another project.

However I have just seen the classes in the flattening folder, in particular, the BlockData implementation there that uses Maps. Ill expand on that keeping into account the network api

[mastercoms]

Hey, I just wanted to drop by and say I really like how this PR is going! I'll have some more feedback on it soon, but just wanted to let you know you're some awesome work!

[smartboyathome]

I saw you removed the WIP tag. I will see about checking out your code and reviewing it here soon. :)

[mosemister]

I mearly removed the [wip] due to all the blocks being added (except noteblock ... Still working out how to do that one). I still need to make sure the code compiles, make sure all the names are correct and all that. That wont change the code that much

[mosemister]

The updated context push fixes the noteblock and missed code. The only check i need to do now is to make sure the ids are as they are in mc

[mosemister]

Should be complete now. All the ids and defaults match. No implementations I have missed.

The network stuff can be removed if needed, ill leave that to whoever wants to take on that issue (it maybe me)

[mosemister]

I will take a deep look in a few days as I have stuff to do. You guys have been doing an amazing job with glowstone, just glad there is code based on my code that will be in it.

Please take your time reviewing it, in no rush.

As for my brief look on the your code, it looks amazing, easy enough to follow. As mentioned before, ill take a good look in a few days.

[smartboyathome]

Closing, as its superseded by #1087.