search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.88k stars 270 forks source link

Move to Gradle #1077

Closed gdude2002 closed 4 years ago

gdude2002 commented 4 years ago

This PR converts the build from Maven to Gradle. No doubt there will be a few teething issues - I'm currently working on getting the build working.

More info is available in this issue.

gdude2002 commented 4 years ago

In case I forgot to say, by the way, this PR is ready for review.

The only thing I'm planning on looking at is the Azure build cache, and that's rumoured to not work properly at the moment.

yannicklamprecht commented 4 years ago

What's the reason to switch to Gradle, when Maven is working fine?

gdude2002 commented 4 years ago

What's the reason to switch to Gradle, when Maven is working fine?

There is a genuinely massive issue (#975) with that discussion in it - it's also linked in the initial comment of this PR.

gdude2002 commented 4 years ago

Some further work needs to be done here for 1.13 to function due to some ridiculously large generated classes requiring some extra args to be passed to the compiler, something which is impossible with the current set of Gradle plugins available.

I'll probably have to write one, but it should be pretty simple. We'll see.

EDIT: Just haven't had time for this lately, but it'll get done.

gdude2002 commented 4 years ago

I am having too much trouble writing a Gradle plugin in a language that isn't Groovy, and the overall plugin architecture doesn't really make sense to me.

As it is currently impossible to work around the stack size requirement (even though we have no good reason to be hitting it) and I don't have the experience required to write a new Lombok plugin that fixes the problem, I'm closing this PR.

I'll leave the branch in place in case someone else wants to take a stab at it.

mastercoms commented 4 years ago

I wouldn't recommend anyone working on it further for the time being. The statically generated class in 1.13 causing the stack overflow will eventually be replaced hopefully.

mastercoms commented 3 years ago

The aforementioned class has been replaced, thanks @smartboyathome!