search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.88k stars 270 forks source link

Remove duplicate options #1081

Closed mio-19 closed 4 years ago

mio-19 commented 4 years ago

these options are already in the configuration file

mastercoms commented 4 years ago

Hi, thank you for your contribution to Glowstone! I think it is useful for people to be able to override their configuration file using command line options. Are there specific benefits to removing this functionality, for example some sort of error or incompatibility?

mio-19 commented 4 years ago

@mastercoms I think people can always easily modify the configuration file, so this functionality is not necessary

aramperes commented 4 years ago

This is useful for running Glowstone using scripts that can't edit YAML files. They are also supported in Spigot: https://www.spigotmc.org/wiki/start-up-parameters/

mio-19 commented 4 years ago

@momothereal Scripts can create a YAML configuration file or use command-line YAML processor

mastercoms commented 4 years ago

Why should we force people to complicate their scripts with YAML processors (and in some cases, including YAML will not be available), for the benefit of a 50 lines of code cleanup and nanosecond level possible startup time improvement?

mio-19 commented 4 years ago

It's not for performance, it's for consistencies and simplicity. Some configurations can specify different values in two places, and some configurations can only be specified in one place

mastercoms commented 4 years ago

While consistency in configuration is a noble cause, these options are commonly used in other server software (despite configuration being available), like CraftBukkit and Spigot. Specifically, many server panels and hosts rely on these options being available to easily manage their server hosting. I don't think we should break compatibility and consistency with other software for this kind of consistency. It doesn't seem valuable enough to me.