search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.88k stars 270 forks source link

Sound id's not always generated properly #1096

Closed SHADOWDANCH closed 2 years ago

SHADOWDANCH commented 4 years ago

Current method of generating minecraft sound id from Sound bukkit enum not always working correctly. For example unable to play shulker open sound because it contains _ in middle part of the name and instead block.shulker_box.open we will get block.shulker.box.open

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/91526797-sound-id-s-not-always-generated-properly?utm_campaign=plugin&utm_content=tracker%2F14691067&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F14691067&utm_medium=issues&utm_source=github).
mastercoms commented 4 years ago

Good catch, I guess we can add an exceptions list + tests? I think it works well for the majority and saves time. Not sure where we can get a list of valid vanilla names though for tests.

mastercoms commented 2 years ago

We're considering using https://github.com/Articdive/ArticData for this.

mastercoms commented 2 years ago

Duplicate of #519.