search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.88k stars 270 forks source link

Add GlowAdvancementDisplay flags #1105

Closed x4e closed 3 years ago

x4e commented 3 years ago

Just implementing a TODO, added flag definitions for the AdvancementDisplay packet writing using wiki.vg.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

x4e commented 3 years ago

@aramperes Thank You for clarifying, I have implemented this in 6ddaaadf.

I think there are probably some issues with the achievement display writing (specifically the icon slot field doesn't seem to be written correctly), but I will leave these for now since you said the dev branch is not really active.

x4e commented 3 years ago

Checkstyle does not like my empty description for the hidden parameter - unfortunately I do not know the purpose of this parameter due to a lack of documentation on wiki.vg.

aramperes commented 3 years ago

From Minecraft Wiki:

hidden: Can be true or false. Whether or not to hide this advancement and all its children from the advancement screen until this advancement have been completed. Has no effect on root advancements themselves, but still affects all their children. Defaults to false.

x4e commented 3 years ago

@aramperes Thanks! Implemented in 5ec1a5a