search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.88k stars 270 forks source link

Utilize RecipeManager and TagManager from Redstone Transformer #1116

Closed smartboyathome closed 2 years ago

smartboyathome commented 2 years ago

This PR swaps out the tags and recipe manager implementations for their counterparts from the redstone transformer. This allows us to get this data from the default datapack easily without keeping that data around and without having to hardcode these recipes. The implementations differ slightly from their Glowstone counterparts, but usually only in name. We may want to switch away from using the MaterialSetTag class to our own wrapper around SubTagTrackingTag in order to allow for modifications to these custom tags to be tracked in the future.

mastercoms commented 2 years ago

Also, I am not sure how relevant materialValues.yml and fishingRewards.yml will be once Redstone Transformer is done, but if they will still be relevant, could you add tag support to both of them?

smartboyathome commented 2 years ago

materialValues.yml currently doesn't have an equivalent in the Redstone Transformer. The data this file contains isn't available from Mojang itself through data packs, but it looks like it is available in PrismarineJS's minecraft-data.

For fishingRewards.yml, this should eventually be replaced by the fishing loot table in Mojang's official data pack.

mastercoms commented 2 years ago

@smartboyathome Could you resolve merge conflicts? Should be good after that.