GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.89k stars 271 forks source link

Flow Noise #134

Closed mastercoms closed 8 years ago

mastercoms commented 8 years ago

Could we use flow noise to replace our internal noise? https://github.com/flow/noise

We already use flow networking.

jimmikaelkael commented 8 years ago

@mastercoms Theoretically it should be possible to use it as long as we use Fractional Brownian motion. The reason I kept it internally is to avoid generation changes if something is changed in an external noise library.

Another bad thing to could come back from using noise libraries (if we use their own fBm method provided that they have one, but here I was thinking about bukkit noise implementation) is the farlands symptoms. You can look at the PerlinOctaveGenerator class where I left a comment at line 47 concerning farlands.

mastercoms commented 8 years ago

I guess we can make a new branch using it and check to see if it has any problems. Though, I am not sure using this library has any benefit, so we will also have to check that too.

mastercoms commented 8 years ago

I tested it, and the noise isn't suitable for Minecraft, really. There were no farlands though.