A few suggestions for the project

twizmwazin commented 8 years ago

Hi, I wasn't terribly sure where this would best fit so I figured I'd just make an issue. I haven't really contributed much to the project (although I'd like to), but I have a few suggestions/complaints about the project.

First, I feel that setup is too complicated. I'd really like a clone-and-go setup. This in my mind would mean splitting off the two submodules and using them as maven dependencies. I really think the current setup is annoying and clunky.
Second, I feel that Glowkit is rather bloated. It seems to have an everything-and-the-kitchen-sink approach right now, with every possible patch included. For lack of a better word I think it is bloated. I feel that the API should be kept as close to upstream as possible, only having small patches that are absolutely necessary to retain functionality. Using the unmodified Bukkit API would be ideal. I feel efforts should go towards implementing the Bukkit APIs before anything else.
I'm not really sure about how to go about fixing this, but I also feel that the project is way to closely tied with Bukkit. This could be somewhat detrimental in the long run, making it difficult to split the project from Bukkit.
A bit petty, but the repo could also be cleaned up a little bit. There are some files in the root that I believe are totally unused.

These are just my suggestions and concerns, I'm curious to see what others agree or disagree on.

Another thing that just popped in to my mind would be a suggestion to move towards a scheduled, stable release model. Currently it is rolling, however a more structured cycle would arguably help the project come together and be closer to releasing a production-ready product.

mastercoms commented 8 years ago

I mean, they are currently maven dependencies, but we don't have repo.glowstone.net set up to provide them, so you have to build them manually.
Yes, Glowkit is bloated so much that there are duplicate methods.
kamcio and I are working on abstracting away from Bukkit.
I'll look into deleting some unused files
I was thinking about starting to version Glowstone++ since we've gotten a lot of bugs fixed and features added so that rolling release is not needed as much.

gdude2002 commented 8 years ago

@mastercoms Whose maven repo were we going to use again?

mastercoms commented 8 years ago

Greatman's

BjoernPetersen commented 8 years ago

Sorry if there is some kind of obvious answer to this question, but couldn't you use the Central Repository?

gdude2002 commented 8 years ago

No, only releases are allowed there, but we need to upload development artifacts.

BjoernPetersen commented 8 years ago

I admit, you still need to specify a snapshot repo in the pom.xml, but you can deploy snapshots to oss.sonatype.org. I never understood why so many people feel the need to host their own repos...

mastercoms commented 8 years ago

Glowkit bloat is fixed. Unnecessary or redundant API features were removed or moved to the server logic.

mastercoms commented 8 years ago

What files do you think should be deleted?

mastercoms commented 8 years ago

Closing as these suggestions have been considered. For further discussion, I would recommend a forum post.

GlowstoneMC / Glowstone

A few suggestions for the project #221