search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.89k stars 271 forks source link

[#396] Entities: Physics [$205] #501

Open gdude2002 opened 7 years ago

gdude2002 commented 7 years ago

Bountysource bounty badge

This issue is part of this story, Completing entities in Glowstone (#396). To make the work easier and bounties fairer, we've split it into multiple issues.

Anyone can participate in the completion of this issue, which will be a major turning point in the development and the possible use-cases for Glowstone as a Minecraft server alternative.

Before getting started! If you are unfamiliar with Glowstone, please remember that Glowstone is a complete rewrite of the Minecraft vanilla server, aimed to be a better alternative to other software like Spigot. You are by no means allowed to push code to this repository based on Mojang's own platform (whether it be Forge, MCP, decompiled binaries, etc.) Doing so will cause in the rejection of your Pull Request. You are allowed to use other resources like the numerous wikis that exist on the Internet (Minecraft Wiki, wiki.vg, etc.) as well as trial-and-error.

Physics

Although we have worked on improving physics recently, there is still much work to do in order to achieve the same results as the Vanilla software. This includes:

--- There is a **[$205 open bounty](https://www.bountysource.com/issues/46548044-396-entities-physics?utm_campaign=plugin&utm_content=tracker%2F14691067&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F14691067&utm_medium=issues&utm_source=github).
birbe commented 4 years ago

I'll work on this when we start polishing our 1.13 versions as this is an essential feature

Mhowser commented 4 years ago

Is Yarn allowed?

mastercoms commented 4 years ago

What is "Yarn" in this context?

Mhowser commented 4 years ago

https://github.com/FabricMC/yarn free mappings for anyone to use

mastercoms commented 4 years ago

Of course not, nor would they even be useful. We don't touch Mojang code at all, and the CLA prohibits Mojang code structures in Glowstone. Now, it may be useful for Linkstone, but that's off topic for this issue.

y6x2digc commented 4 years ago

Of course not, nor would they even be useful. We don't touch Mojang code at all, and the CLA prohibits Mojang code structures in Glowstone.

How about other open source implementations such as cuberite?

mastercoms commented 4 years ago

Referring to other code can be useful, as long as it is done under their own license/terms. Please also keep in mind that some servers do not have the same level of cleanroom requirements as Glowstone. I do not know enough about Cuberite to specifically approve it but as long as it follows the requirements of no Mojang code, and your usage meets all licensing requirements, then it should be fine.

x4e commented 3 years ago

@gdude2002 could we get an update on the status of this issue?

I would be happy to help however I am a bit confused about which parts of this have already been implemented.

The issue states that velocity needs to be implemented but from what I can tell this has been.

Item dropping also seems to look alright.

From looking at the code it seems that liquid drag has been implemented (if by this you mean slower movement in water. If you mean entities being pulled by the flow, then this hasn't been implemented).

I would however be happy to implement

As these don't seem to be implemented.

mastercoms commented 3 years ago

The physics we have now are non-ideal and worth replacing entirely. There's many bugs with incorrect physics and discrepancies compared to vanilla, as well as some weird stuttering issues for some entity movement. So even if something is implemented currently, I would say it's up for grabs to do as part of this issue.