search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.9k stars 273 forks source link

Update setup.sh #806

Closed josephworks closed 6 years ago

josephworks commented 6 years ago

your old script was BAD...

josephworks commented 6 years ago

installs dependencies and runs commands to check environment before building a clean install package

mastercoms commented 6 years ago

Hi thanks for your contribution, but this PR doesn't further the goals of the setup.sh script. System dependency management is going to be something that will be very platform specific so a script managing this must be much more robust to support a wider variety of systems. As such, the script cannot be accepted in this state, even in a new file.

Also, I feel like the specifications for such a script would be too complex to support many systems reliably, and thus it should be up to the user to find and install the dependencies on their machine, rather than having a script to do this for them.