search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.9k stars 273 forks source link

Fix cactus dropping invalid item #832

Closed XuZhen86 closed 6 years ago

XuZhen86 commented 6 years ago

This pull request mainly tries to fix a bug that the cactus will drop purple block when the internal data is not 0. It also fixes a typo and improves Javadoc.

Observed behavior: Cactus drops purple block randomly when break, as seen in the screen shot below. The purple blocks also groups together based on the data value. This bug occurs more often when the cactus block is on top of a growing cactus. 2018-01-30_10 21 37

Expected behavior: Cactus should always drop cactus item when break.

Other known issues:

  1. The check style seems to fail on codes related to arrow?
  2. When breaking a 3-blocks tall cactus or sugar cane, the items will drop but disappears right after they touch the floor.
XuZhen86 commented 6 years ago

The title gone wild lol

screen shot 2018-01-30 at 11 12 56 am
mastercoms commented 6 years ago

Merged. Thank you for your contribution to Glowstone!