Migrate non-PowerMock unit tests to Jupiter

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition

https://glowstone.net

Other

1.9k stars 273 forks source link

Migrate non-PowerMock unit tests to Jupiter #842

Closed Pr0methean closed 6 years ago

Pr0methean commented 6 years ago

Tests that use PowerMock will have to use the Vintage API until powermock/powermock#830 is fixed, but this PR converts all others to the Jupiter API (i.e. makes them real JUnit 5 tests, instead of JUnit 4 tests running on JUnit 5).

kacperduras commented 6 years ago

Is it better to gradually pass unit tests on a newer version of Junit? It has backward compatibility, so you do not have to do it at the same time only successively.

Pr0methean commented 6 years ago

Yes, the rest will be done gradually. This PR covers only the simple cases.

Oh wait, are you asking about the opposite -- splitting up this PR to convert one test at a time? I've been told that doing refactors that way creates too many different PRs and spams people's notifications.