GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.9k stars 273 forks source link

Linkstone runtime support #952

Closed aki-ks closed 3 years ago

aki-ks commented 6 years ago

This PR redirects uses of fields annotated with a @Field annotation to the corresponding getter and setter methods. Regular invokes and reflective accesses will be redirected.

Glowkit#20 must be merged for this PR.

aki-ks commented 6 years ago

Linkstone#4 must also be merged and the "annotation" and "runtime" submodules must be published onto a repository.

WesleyVanNeck commented 6 years ago

what is linkstone ?

MatrixTunnel commented 6 years ago

This explains it pretty well https://github.com/GlowstoneMC/Linkstone/blob/master/README.md

mastercoms commented 6 years ago

@aki-ks What is the status of this PR? Do you think it could be reviewed for merge in its current state?

aki-ks commented 6 years ago

Yes, I think so, but you must first make the linkstone-runtime and linkstone-annotations dependency available to the project (publish it on glowstone's maven repo).

mastercoms commented 5 years ago

This is currently blocked by Linkstone getting a working CircleCI build.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: mastercoms
:x: aki_ks


aki_ks seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

mastercoms commented 3 years ago

Linkstone is now deployed to our Maven repo, through GitHub Actions, so this PR is no longer blocked.

mastercoms commented 3 years ago

aki-ks has signed the CLA, but the bot does not recognize the slightly renamed username.