Closed aki-ks closed 3 years ago
Linkstone#4 must also be merged and the "annotation" and "runtime" submodules must be published onto a repository.
what is linkstone ?
This explains it pretty well https://github.com/GlowstoneMC/Linkstone/blob/master/README.md
@aki-ks What is the status of this PR? Do you think it could be reviewed for merge in its current state?
Yes, I think so, but you must first make the linkstone-runtime
and linkstone-annotations
dependency available to the project (publish it on glowstone's maven repo).
This is currently blocked by Linkstone getting a working CircleCI build.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: mastercoms
:x: aki_ks
Linkstone is now deployed to our Maven repo, through GitHub Actions, so this PR is no longer blocked.
aki-ks has signed the CLA, but the bot does not recognize the slightly renamed username.
This PR redirects uses of fields annotated with a
@Field
annotation to the corresponding getter and setter methods. Regular invokes and reflective accesses will be redirected.Glowkit#20 must be merged for this PR.