search

GlowstoneMC / Glowstone

A fast, customizable and compatible open source server for Minecraft: Java Edition
https://glowstone.net
Other
1.89k stars 271 forks source link

Fix compilation error. #972

Closed cedws closed 5 years ago

cedws commented 5 years ago

This PR fixes a compilation error caused by a method signature change in flow-network, updated in commit c6e1ed01170598006ca16dc3cebd08723d20b3eb.

This PR does not pass the CheckStyle rules. I spent a few hours trying to get CheckStyle to apply the style rules but gave up out of frustration.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

cedws commented 5 years ago

I would be okay with signing the CLA, but the service requires access to see my private email address. Let me know if you have any workarounds for this.

mastercoms commented 5 years ago

@c-edw Please just state that you, c-edw, have read and agree to the Glowstone CLA. You won't need to use the tool then.

But yeah, we might be reverting this change to flow-network, so this PR might be rejected because of that.

Finally, the reason why the check style is not passing is because the lines are too long. You would have to add new lines after a comma for method parameters to fix it for this PR.

cedws commented 5 years ago

I have read and agree to the Glowstone CLA.

Yup, that's fine. I would humbly like to suggest keeping dev in a state that passes CI. I wasn't sure if nobody had the time to fix it, or just didn't notice it.

Thanks guys.