search

GlowstoneMC / ShinySponge

Sponge API experiments - nothing serious here.
3 stars 2 forks source link

Needs to be updated for Sponge API 1.1 #1

Open gdude2002 opened 9 years ago

gdude2002 commented 9 years ago

^

gdude2002 commented 9 years ago

Also, support for this would be nice (as seen in the test plugin)

    @Inject @Named("GeneralConfigDir")
    public File main_config_dir;
    @Inject @Named("PluginConfigFile")
    public File rec_config_file;
    @Inject @Named("PluginConfigDir")
    public File rec_config_dir;
SpaceManiac commented 9 years ago

Those injections added in 7e892bb98264ac29ca58c25e6c29744da151fc63.

gdude2002 commented 9 years ago

<3

deathcap commented 9 years ago

There are now more methods needed to compile ShinySponge against the latest SpongeAPI 1.1-SNAPSHOT:

https://github.com/deathcap/ShinySponge/commits/sponge11

but I'm not sure if this is the right way to do it. Had to add a bunch of stubs since the Shiny classes directly implement the SpongeAPI interfaces. Isn't this the problem "mixins" are intended to solve?

https://github.com/SpongePowered/Mixin