search

Glucosio / glucosio-android

Glucosio Android App
GNU General Public License v3.0
338 stars 162 forks source link

Add F-Droid Build Flavor #219

Closed ghost closed 8 years ago

ghost commented 8 years ago

F-Droid has a non-free policy that does not allow the use of Private API's in order to support their platform as a distribution channel we need a build we will call "fdroid" which will need to be free of all third party API's as of our current release this means we will need to remove:

play-services (Crash Data, Sharing, Google Drive Backup) and smooch (Feedback, Support)

This build should also disabled any UI elements which point to features enabled by these third party API's being removed.

We will evaluate what degree of support we can provide to end users on F-droid which may be limited by these restrictions.

mvdan commented 8 years ago

@PaoloRotolo works now, update should be out tomorrow

paolorotolo commented 8 years ago

@mvdan nice!

paolorotolo commented 8 years ago

@mvdan Looks like there were an issue building the latest version (the version on F-Droid is the 1.1.2-FOSS, added on 2016-07-19).

mvdan commented 8 years ago

@PaoloRotolo yeah, see https://f-droid.org/wiki/page/org.glucosio.android/lastbuild_34. I'm away at the moment, will look into it tomorrow. You can close this issue if you want, this is just a build issue on our end.

paolorotolo commented 8 years ago

@mvdan Cool. Nice that we sorted this out and thanks for your efforts.

mvdan commented 8 years ago

If in the future you have any issues, you can either open an issue here and ping me and/or @krt16s or you can open an issue here: https://gitlab.com/fdroid/fdroiddata/issues

We prefer the latter since it doesn't limit the pinging to us two.

mvdan commented 8 years ago

@PaoloRotolo so the issue is that you force Gradle 2.13 via gradleVersion but you use a newer plugin version that requires 2.14.1 or newer. This results in us using 2.13 and this:

   > Minimum supported Gradle version is 2.14.1. Current version is 2.13. If using the gradle wrapper, try editing the distributionUrl in /home/vagrant/build/org.glucosio.android/app/gradle/wrapper/gradle-wrapper.properties to gradle-2.14.1-all.zip
paolorotolo commented 8 years ago

That's strange, it built fine on our machines and CI (https://travis-ci.org/Glucosio/glucosio-android/builds/153553307). I will have a look at it anyway.

paolorotolo commented 8 years ago

Hey @mvdan, sorry for my delay but we were planning a bugfix release this weekend. I have updated the foss branch as well with tag 1.2.1-foss.

https://github.com/Glucosio/glucosio-android/releases/tag/1.2.1-foss

ghost commented 8 years ago

Is this is resolved can we close this issue?

ghost commented 8 years ago

1.2.1 got build, however, 1.3.0 is missing both, the actual 1.3.0-foss tag as well as any changes to the https://github.com/Glucosio/glucosio-android/commits/foss-only branch

paolorotolo commented 8 years ago

I'll port the changes to the Foss branch this afternoon.

paolorotolo commented 8 years ago

@krt16s Here you go: https://github.com/Glucosio/glucosio-android/releases/tag/1.3.0-foss

ghost commented 8 years ago

Thanks. 1.3.0 has been build, so imho this can be closed.

ghost commented 6 years ago

Just an update here since we have lost our full time Android lead @paolorotolo who can only contribute occasionally we are not able to update the foss only branch anymore as we do not have the resources to do this.

Right now the f-droid version is outdated from upstream but if someone from f-droid would like to continue to build off upstream and make necessary changes downstream that works for us.