Glucosio / glucosio-android

Glucosio Android App
GNU General Public License v3.0
338 stars 162 forks source link

Modified error code of a1c converting #326

Closed raacker closed 8 years ago

raacker commented 8 years ago

I was writing test code of A1CCalculaterPresenter and there was a logical error.

if user prefers percentage, it should be convertedto mmol/mol.

but it is calling NgspToIfcc when it is not percentage.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.02%) to 15.094% when pulling de3a74ae5cc87e798806d57533cdd5a54f9e4f80 on raacker:a1cpresenter into f36f89008cae5205ea9fa7d9804ccf9beef0f38a on Glucosio:develop.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.02%) to 15.094% when pulling de3a74ae5cc87e798806d57533cdd5a54f9e4f80 on raacker:a1cpresenter into f36f89008cae5205ea9fa7d9804ccf9beef0f38a on Glucosio:develop.

paolorotolo commented 8 years ago

Hey, is this still valid? Why did you close the pull?

raacker commented 8 years ago

Hmm.. I understood wrong! This method should return a1c value and if user preferred mmol, it has to convert from percentage to mmol!

Nope. It is invalid :) so I swapped codes for more readability

paolorotolo commented 8 years ago

Okay, thanks anyway :)

raacker commented 8 years ago

Thanks! :)