Refactor AddReadingPresenter

Glucosio / glucosio-android

Glucosio Android App

GNU General Public License v3.0

338 stars 162 forks source link

Refactor AddReadingPresenter #341

Closed jeonsoh closed 7 years ago

jeonsoh commented 7 years ago

setReadingTimeNow and updateReadingSplitDateTime have duplicated codes
getReadingCal and getReadingTime have same problem

coveralls commented 7 years ago

Coverage increased (+0.03%) to 15.661% when pulling a4f3e90698056358797dc94180b138082295b347 on jeonsoh:refactorAddReadingPresenter into 27678f88e550ad50170dfa873d83f331fb02a46d on Glucosio:develop.

emartynov commented 7 years ago

Thank you for the contribution!

Are these methods ever used? I see you changed methods itself but I don't see you changed places where they were used.

raacker commented 7 years ago

Seems removed duplicated codes. There are some codes that have totally same functionality.

Looks Okay!

jeonsoh commented 7 years ago

Yes. raacker is right. I tend to just remove duplicated codes. So, not effect on any other codes.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 15.667% when pulling 78b93fee9b84e4a89f434c3addf195f3d7316b3c on jeonsoh:refactorAddReadingPresenter into 702fa6b1016841fb5597d73acba610bed88df39c on Glucosio:develop.

jeonsoh commented 7 years ago

Okay! I modified that part, changed to new Date(). Thank you very well!