Add request data - Githubissues

GlueDev / laravel-stackdriver

Enables logging, tracing and error reporting to Google Stackdriver for Laravel

MIT License

47 stars 26 forks source link

Add request data #20

Open vincentrolfs opened 4 years ago

vincentrolfs commented 4 years ago

Remove call to Bootstrap::exceptionHandler and do the boilerplate work ourselves in order to be able to send more data to error reporting
Send the following data to error reporting (in addition to what we have always sent):
- User id
- Request URL
- Request method (GET, POST, ...)
- User agent
- Referrer URL
- Client IP
Enable users to supply additional context data as they wish

vincentrolfs commented 4 years ago

Things to note:

I am not sure if it could be a problem with GDPR that we are automatically logging user id, user agent and client IP on error. Maybe this should be opt-in.
I had to copy some code from Google\Cloud\ErrorReporting\Bootstrap which was private static. This code is licensed under Apache 2.0 which is different from our license (MIT). Not sure what the implications of this are.

DiederikvandenB commented 4 years ago

Hi, I am sorry, this slipped off my radar.

I indeed do think that adding user data is a bit tricky given GDPR. I think we better make this opt-in. Having checked the Apache 2.0 license, I don't think we'll have any issues here including that code.