search

GluuFederation / agama-pw

Agama Project for all things password: identifier first, password expiration, account lockout.
Apache License 2.0
6 stars 17 forks source link

fix: sample configuration should use standard naming #21

Open ossdhaval opened 3 months ago

ossdhaval commented 3 months ago

The sample configuration downloaded using TUI for agama-pw flow uses temporary name for flow name. This should be avoided.

To get the file:

  1. Open TUI
  2. Upload agama-pw project (rel: 1.0.1)
  3. Once the project gets uploaded without errors, select the project and press c
  4. Select download sample configuration

image

mmrraju commented 3 months ago

Please check with latest release v1.0.2 .

ossdhaval commented 2 months ago

Hi @mmrraju

Yes, I can see the changes in the sample file content but I would like to know why there are two top level elements in the sample JSON.

The sample config that I downloaded has the below content:

{
  "": {},
  "org.gluu.agama.pw.main": {}
}

While the README config section shows only one.

Can you bring these two in synch?

mmrraju commented 2 months ago

@syntrydy , could you please help on this?

ossdhaval commented 1 month ago

@syntrydy @mmrraju Let's get this to completion. Like in other projects(see sample conf of agama-sms or totp), the content of sample should be meaningful. Like what is in the readme here.