search

GluuFederation / gluu-passport

Gluu interface to Passport.js to support social login and inbound identity.
Apache License 2.0
6 stars 17 forks source link

Centralize one source for configuration #414

Open kdhttps opened 2 years ago

kdhttps commented 2 years ago

close #382 task-2

@christian-hawk first two are done but still need your to view on this https://github.com/GluuFederation/gluu-passport/issues/382#issuecomment-993468657

codecov[bot] commented 2 years ago

Codecov Report

Merging #414 (31572ef) into master (09221af) will increase coverage by 0.61%. The diff coverage is 100.00%.

:exclamation: Current head 31572ef differs from pull request most recent head 4f0fc9e. Consider uploading reports for the commit 4f0fc9e to get more accurate results

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   78.58%   79.20%   +0.61%     
==========================================
  Files          36       36              
  Lines         780      803      +23     
==========================================
+ Hits          613      636      +23     
  Misses        167      167
Impacted Files Coverage Δ
config/test.js 100.00% <ø> (ø)
server/app-factory.js 94.28% <100.00%> (+0.16%) :arrow_up:
server/app.js 96.00% <100.00%> (+0.87%) :arrow_up:
server/utils/http-global-proxy.js 100.00% <100.00%> (ø)
server/utils/rate-limiter.js 100.00% <100.00%> (ø)
server/utils/session.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09221af...4f0fc9e. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

christian-hawk commented 2 years ago

close #382 task-2

  • [x] rate-limit config
  • [x] session config
  • [ ] proxy config

@christian-hawk first two are done but still need your to view on this #382 (comment)

I agree with you https://github.com/GluuFederation/gluu-passport/issues/382#issuecomment-1073459229

So proxy config is not done yet? If is not done please change PR to draft and request review when ready. Thanks mate :)

kdhttps commented 2 years ago

So proxy config is not done yet? If is not done please change PR to draft and request review when ready. Thanks mate :)

not done yet mate, sure I will do, thank you :)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication