GluuFederation / gluu-passport

Gluu interface to Passport.js to support social login and inbound identity.
Apache License 2.0
6 stars 17 forks source link

refactor: use ESM modules #426

Open kdhttps opened 2 years ago

kdhttps commented 2 years ago

close #409

Major Changes:

  1. nyc package does not support ESM modules. Used c8 instead of it.
  2. rewire package does not support ESM modules. For work around exports all submodules. There are other packages but they need to build using babel. more details
  3. sinon does not support ESM modules. Used esmock instead of it
codecov[bot] commented 2 years ago

Codecov Report

Merging #426 (ba761f0) into master (d61566e) will increase coverage by 8.89%. The diff coverage is 97.76%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   78.58%   87.48%   +8.89%     
==========================================
  Files          36       24      -12     
  Lines         780     2198    +1418     
  Branches        0        3       +3     
==========================================
+ Hits          613     1923    +1310     
- Misses        167      275     +108     
Impacted Files Coverage Δ
config/default.cjs 100.00% <ø> (ø)
config/production.cjs 100.00% <ø> (ø)
config/test.cjs 100.00% <ø> (ø)
server/utils/uma.js 92.09% <89.28%> (-6.46%) :arrow_down:
server/routes.js 59.81% <90.00%> (-3.15%) :arrow_down:
server/app-factory.js 95.55% <100.00%> (+1.43%) :arrow_up:
server/app.js 90.19% <100.00%> (-4.93%) :arrow_down:
server/cache-provider.js 84.29% <100.00%> (+49.00%) :arrow_up:
server/extra-passport-params.js 100.00% <100.00%> (ø)
server/idp-initiated.js 55.86% <100.00%> (+2.63%) :arrow_up:
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d61566e...ba761f0. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

christian-hawk commented 2 years ago

run tests

christian-hawk commented 2 years ago

run tests