Open GlynisF opened 9 months ago
Thanks @GlynisF and @misterSokor. Can you please post your presentation that demonstrates the items listed on this page: http://paulawaite.com/education/java113/Module3/Week12/index.html.
This helps me understand the project and where to focus my time when reviewing code. Thanks!
Hi @GlynisF and @misterSokor. After watching your team's presentation, I have a number of questions which I posted in slack and am copying here since slack messages will archive after 90 days and I don't want to lose that information. Please respond to the questions either here and in Slack, or simply here.
Presentation comments and questions
I think you mentioned JavaFX. Can you share more about what that is, and why you chose to use it in this project? What benefit did it provide over the structure for java applications that we have been using?
From the code review and demo, it looks like the code in your project consumes a weather service and has a web front end as an interface to that service. Did I understand correctly that this is a web application?
Is there an aspect of this project that is a RESTful api? Meaning we could access it using soapui or postman, sending in a request and receiving a response? Creating a RESTful api was the goal of the team project.
A few things I was looking for in your presentation that were missing:
a. User documentation - this is the documentation somebody consuming a service would use to understand how to use your service. The petstore api has an excellent example of user documentation: https://petstore.swagger.io/ It shows the resources, such as pet, store, etc., and the various “operations” it supports. b. Demonstration of calling your restful api. Use soapui, postman, curl, etc. b. Unit tests? c. Challenges and Key learning points? Ideally each team member shares this.
Project Code Review
In the interest of time, I'm mostly going to focus on areas for improvement so that you can use this learning in your indie project. Note that I reviewed the main branch only.
Kudos:
Areas for improvement:
Hi Paula-- we made changes to our project and are ready for review.
We don't have a database implemented, but I think/hope the changes we made demonstrates implementing rest.
@pawaitemadisoncollege