Gmousse / dataframe-js

No Maintenance Intended
https://gmousse.gitbooks.io/dataframe-js/
MIT License
460 stars 38 forks source link

[BUG] Definitions for filter and where functions missing boolean option #135

Open ajdaling opened 1 year ago

ajdaling commented 1 year ago

Typings for filter and where functions are missing boolean option for condition. Using these functions as described in the documentation:

df.filter(row => row.get('column1') >= 3)

throws the following TS error: Type 'boolean' is not assignable to type 'DataFrame | Record<string, any>'.ts(2322)

Function definitions need to be updated to: where(condition: (row: any) => DataFrame | Record<string, any> | boolean): DataFrame; filter(condition: (row: any) => DataFrame | Record<string, any> | boolean): DataFrame;