search

Gmousse / dataframe-js

No Maintenance Intended
https://gmousse.gitbooks.io/dataframe-js/
MIT License
460 stars 38 forks source link

[BUG] The documentation is wrong about toJSON first parameter #84

Closed ultimumdesign closed 5 years ago

ultimumdesign commented 5 years ago

Describe the bug Thank you for your work. This issue is primarily to thank you, but there is one tiny tiny issue at the toJSON function: src/dataframe.js:505-513

The inline and official documentation states: @param asCollection default = true but.. on the function definition it is set to false?

Cheers!

Gmousse commented 5 years ago

Hi @ultimumdesign,

Thank you for your question.

Indeed, that's strange, the documentation is wrong about this default parameter which is = to false for now.

I will find when the regression occured and I will fix it in the next patch.

Gmousse commented 5 years ago

I couldn't find the regression, I guess this documentation error exists since the begin.

Gmousse commented 5 years ago

Pushed on develop. It will released soon.