search

Gmousse / dataframe-js

No Maintenance Intended
https://gmousse.gitbooks.io/dataframe-js/
MIT License
460 stars 38 forks source link

[Feature] Adding renameSome method for selectively renaming multiple columns at once #91

Open anusha5695 opened 5 years ago

anusha5695 commented 5 years ago

PR for #90

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.04%) to 94.76% when pulling 86d1061859a8d86f961da35489f188ccf8e173d0 on anusha5695:renameSome into 6ad744a1699f0bd0928f4a33ac4ca94b7d4afe16 on Gmousse:develop.

Gmousse commented 5 years ago

Hi @anusha5695, Thank you for this PR ! That's clean ! Just fix the few details (nothing about mechanics, just about notation). To conclude that's a great job.

I think I will create another PR in order to complete your work and apply what I said about the .rename method.

The aim is:

I hope you can review this.

anusha5695 commented 5 years ago

Hi @Gmousse: Okay. Can i pick that if that's not a problem?

anusha5695 commented 5 years ago

And this - "Just fix the few details (nothing about mechanics, just about notation)" . What should be fixed? I ll put them in the next commits.

Gmousse commented 5 years ago

Hey ! Of course you can pick it. Go Go ! :)

What should be fixed ?

Just the few comments I made about doc, or code style. Sorry, that was not clear :D.

anusha5695 commented 5 years ago

Cool. will push the changes over the weekend

anusha5695 commented 5 years ago

Hi @Gmousse : I guess the dist and bin folder would be built. Right?

Also have pushed in the new changes. Please review :)

anusha5695 commented 5 years ago

Hi @Gmousse have you started reviewing the changes?

Gmousse commented 5 years ago

Hi ! sorry to be late :D (I was busy and the vacation doesn't help)

You can now read my review

anusha5695 commented 5 years ago

Hi @Gmousse : Sorry to bother on a vacation :D . Looked at the comments. Will make changes and push over the weekend