Open anusha5695 opened 5 years ago
Hi @anusha5695, Thank you for this PR ! That's clean ! Just fix the few details (nothing about mechanics, just about notation). To conclude that's a great job.
I think I will create another PR in order to complete your work and apply what I said about the .rename
method.
The aim is:
I hope you can review this.
Hi @Gmousse: Okay. Can i pick that if that's not a problem?
And this - "Just fix the few details (nothing about mechanics, just about notation)" . What should be fixed? I ll put them in the next commits.
Hey ! Of course you can pick it. Go Go ! :)
What should be fixed ?
Just the few comments I made about doc, or code style. Sorry, that was not clear :D.
Cool. will push the changes over the weekend
Hi @Gmousse : I guess the dist and bin folder would be built. Right?
Also have pushed in the new changes. Please review :)
Hi @Gmousse have you started reviewing the changes?
Hi ! sorry to be late :D (I was busy and the vacation doesn't help)
You can now read my review
Hi @Gmousse : Sorry to bother on a vacation :D . Looked at the comments. Will make changes and push over the weekend
PR for #90