Gmousse / dataframe-js

No Maintenance Intended
https://gmousse.gitbooks.io/dataframe-js/
MIT License
460 stars 38 forks source link

[BUG] installing with pnpm throw exception on runtime #93

Closed raz-viber closed 5 years ago

raz-viber commented 5 years ago

Describe the bug after installing dataframe-js with pnpm I tried to do: require('dataframe-js').DataFrame and got:

Error: Cannot find module 'regenerator-runtime/runtime' at Function.Module._resolveFilename (module.js:489:15) at Function.Module._load (module.js:439:25) at Module.require (module.js:517:17) at require (internal/module.js:11:18) at Object. (/Users/raz/viber/test/node_modules/.registry.npmjs.org/dataframe-js/1.4.2/node_modules/dataframe-js/lib/dataframe.js:40:1) at Module._compile (module.js:573:30) at Object.Module._extensions..js (module.js:584:10) at Module.load (module.js:507:32) at tryModuleLoad (module.js:470:12) at Function.Module._load (module.js:462:3)

To Reproduce

Expected behavior to work...

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context package.json:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "dataframe-js": "^1.4.2"
  }
}

P.S even after installing

babel-runtime

as suggested (https://github.com/pnpm/pnpm/issues/1435#issuecomment-432410096) did not helped

the flag shamefully-flatten did worked but it not suite for our entire project

Gmousse commented 5 years ago

Hi @raz-viber,

Thank you for your report. I m not a pnpm user, let me get few documentation about this and I will find a fix.

Gmousse commented 5 years ago

Hi @raz-viber, Could you try to test this branch ? pnpm i git+https://github.com/Gmousse/dataframe-js.git#release/1.4.3

It seems to work now. Its related to #88 and this babel environment nightmare.

raz-viber commented 5 years ago

works like a charm!

thanks! @Gmousse

Gmousse commented 5 years ago

Nice ! I will publish the fix release tommorow

Gmousse commented 5 years ago

It must be fixed on the new 1.4.3. Thanks for your patience