Open chenxinyanc opened 5 years ago
Hi @chenxinyanc, Thank you for your report.
JS ecosystem can be an incredible mess sometimes. I will see to create a temporary workaround (I can't drop core-js just like that, or I will take one thousand issues). Stay tuned.
I have the same issue. Any update?
Sorry I was in holidays, I will try to fix it monday.
Sorry for the delay, I wasn't active on github these days. I m working on a solution.
Describe the bug Please remove the following line https://github.com/Gmousse/dataframe-js/blob/9d6226a62667b8882276bd190eb520086d57ee2e/lib/io.js#L9
Actually, I don't think it should ever be library's responsibility to set up polyfills. You may require user to install and configure them by themselves.
This package have hard dependency on
core-js/promise
polyfill. When used with Angular, we cannot ensure Promise polyfill is loaded before zone.js (a dependency of Angular) is loaded. Note that we are using separate js files and the js file usingdataframe-js
is loaded after the Angular app is loaded. Due to angular/zone.js#783 and zloirock/core-js#319, whencore-js/promise
module is loading, it will replacewindow.Promise
fromZoneAwarePromise
(patched by zone.js) back to nativePromise
, and breaks Angular's change detection.To Reproduce Steps to reproduce the behavior:
Expected behavior
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context