search

GnaspGames / Smelt

A CLI tool for Minecraft map makers
http://smelt.gnasp.com
MIT License
19 stars 4 forks source link

startModuleZ has no effect on Z coordinate starting position #82

Closed ckwakman closed 7 years ago

ckwakman commented 7 years ago

Increasing "moduleStartZ": 0 to "moduleStartZ": 1 will raise the module by one in the y-axis when expected behaviour would be movement on the z-axis

GnaspGames commented 7 years ago

Thanks for the bug report.

I'll have a look into it.

GnaspGames commented 7 years ago

Yup, looks like a type here:

https://github.com/GnaspGames/Smelt/blob/20f4970cff694961353ebeedd60f7b0cb11a7688/Compiler/CommandCreator.js#L394

The parameters startX, startZ, startY are being passed through in the wrong order.

I'll submit a fix and release a new pre-release. I'm not in a position to test the fix at the moment, would you be able to let me know if it works?

If so, I think it's about time that I finish the pre-release cycle and release 1.1.0 properly.

Thanks!

GnaspGames commented 7 years ago

1.1.0-pre9 has now been released. Let me know how you get on?

ckwakman commented 7 years ago

Sure, I'll test it!

2017-01-17 22:24 GMT+08:00 Gnasp notifications@github.com:

1.1.0-pre9 has now been released. Let me know how you get on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GnaspGames/Smelt/issues/82#issuecomment-273178815, or mute the thread https://github.com/notifications/unsubscribe-auth/AT-L29s-HNrDfYwo13hmFsfHRap-WLwMks5rTM8ogaJpZM4LlHaW .

GnaspGames commented 7 years ago

bananenbroek4 - 01/21/2017 I don't think moduleStartZ works still Y works now though

GnaspGames commented 7 years ago

@bananenbroek4 Sorry it's taken a while; but this should now be fixed in 1.1.0-pre10.