search

GnaspGames / Smelt

A CLI tool for Minecraft map makers
http://smelt.gnasp.com
MIT License
19 stars 4 forks source link

#94 the fix for markerTags not showing up on plugin created commandBlocks #97

Closed mrjvs closed 7 years ago

GnaspGames commented 7 years ago

This is the implementation for #94

Honestly I'm a little unsure whether marker entities should be created inside plugins. I can see someone setting it without realising that it will create many more than intended if they use a bang command before resetting it.

But I'm happy to let this go and see what happens.

mrjvs commented 7 years ago

@GnaspGames To fix the more than intended in the delay plugin I used the setJSON function that is also suggested in a pullrequest.

GnaspGames commented 7 years ago

Right, I see now! Your setting the markerTag INSIDE the band command, and needed it to revert back to whatever was before the bang command was called.

Actually that's what happens with the other JSON props like type and auto.

https://github.com/GnaspGames/Smelt/blob/master/BangCommands/Helper.js#L21

This stops JSON properties from persisting for more than one command when used in a band command. I think I would prefer the markerTag to behave the same so that it's consistent.

I've already started adding to this on my local version, so I'll look into it. There won't be a need for .setJSON then.

mrjvs commented 7 years ago

Great, but not a single markertag is created on plugin created command block even when the markertag is declared before the the bang command.

GnaspGames commented 7 years ago

Yes, that will be implemented too. I've got this. 👍