Gnimuc / CImGui.jl

Julia wrapper for cimgui
https://github.com/cimgui/cimgui
MIT License
253 stars 25 forks source link

1.90.8 and backend shenanigans #122

Closed JamesWrigley closed 2 months ago

JamesWrigley commented 3 months ago

I began the bindings update to 1.90.8 and ran into a bunch of things that needed fixing in our backends, so I decided to try using the official GLFW/OpenGL3 backends instead. And amazingly, they seem to work :octopus: This isn't ready to merge yet but I'm opening it for transparency. demo/demo.jl should work, but not example/demo.jl yet.

How to test it:

JamesWrigley commented 2 months ago

Fixes #123. Sneaky proof using the new test engine wrapper :smirk: cimgui-tests

JamesWrigley commented 2 months ago

While fixing the existing tests and getting CI to pass I realized that package extensions were only added in 1.9... I don't think I can be bothered supporting Requires and all that for older versions so I just bumped the minimum Julia version. There's still two failures on nightly for OSX and Ubuntu, but they both seem to be issues with loading GLFW.

JamesWrigley commented 2 months ago

I tried to add x86 tests to CI, but got this error when creating a GLFW window: Invalid window size -389703880x100 Not sure what's going on there, AFAICT it's unrelated to CImGui. But we weren't testing x86 before anyway so I don't think it's a blocker.