Gnimuc / CImGui.jl

Julia wrapper for cimgui
https://github.com/cimgui/cimgui
MIT License
253 stars 25 forks source link

Add support for setting the OpenGL version #132

Closed JamesWrigley closed 1 month ago

JamesWrigley commented 2 months ago

Also removed the explicit GLFW.Init()/GLFW.Terminate() calls since GLFW will do that automatically.

@Gnimuc, @sairus7, does this look reasonable? I tried to preserve the previous behaviour, except for defaulting to OpenGL 3.2 on non-OSX systems.

JamesWrigley commented 2 months ago

(if there's no objections I'll merge this in the next few days)

sairus7 commented 2 months ago

I don't know if we would need several backends, but it looks good.

JamesWrigley commented 2 months ago

Do you mean like for SDL etc? Yeah some options may eventually be specific to their backends, at that point we'll just have to document them as such.