search

Gnimuc / CImGui.jl

Julia wrapper for cimgui
https://github.com/cimgui/cimgui
MIT License
259 stars 25 forks source link

InvisibleButton should take three arguments #50

Closed PinkMushroom closed 3 years ago

PinkMushroom commented 3 years ago

If you look at this issue in imgui (NOT CImGui)

https://github.com/ocornut/imgui/issues/3370

you will see that InvisibleButton should take 3 arguments, the last being flags.

However when I execute InvisibleButton with 3 arguments I get:

│ MethodError: no method matching InvisibleButton(::String, ::ImVec2, ::UInt32) │ Closest candidates are: │ InvisibleButton(::Any, ::Any) at /home/briand/.julia/packages/CImGui/vVLHW/src/wrapper.jl:1104 └ @ Renderer ~/src/julia/imgui/test1/Renderer.jl:77

Seeing that the 3rd argument change was in mid-2020, i'm wondering if maybe CImGui may need a minor update ?

Gnimuc commented 3 years ago

Which version are you using?

PinkMushroom commented 3 years ago

someday i'll remember to put that information in the issue...

[5d785b6c] CImGui v1.77.1

Gnimuc commented 3 years ago

This is fixed on v1.79, would you mind doing an upgrade? If not, I can backport those commits.

PinkMushroom commented 3 years ago

I upgraded to Julia 1.6.1 and that pulled in 1.79. Thank you !