search

GnomeSnapExtensions / gSnap

Gnome-shell extension that allows you to move windows into specific regions similiar to FancyZones on windows.
https://extensions.gnome.org/extension/4442/gsnap/
Other
166 stars 23 forks source link

New Option: Prevent window snapping with Super key. #79

Closed asteinba closed 5 months ago

asteinba commented 12 months ago

Hi,

I just started using gSnap, wonderful extension! This PR adds a new option that allows to prevent window snapping by holding down the Super key.

Motivation:

I really like the automatic snapping (so without the need to press CTRL) but from time to time I want to loosely position a window. I added this option so that you can hold Super to disable the window snapping (so basically the opposite from the CTRL option).

Also I'm using the Super key to move (with left click) and resize (with right click) windows but this doesn't work with automatic snapping.

I also think the Super key is the perfect candidate for this as you already use Alt and CTRL for other options.

I hope this feature is fine. Let me know if I need to do any further adjustments :).

Edit: Ah and I just noticed the isHolding function was not working for the SUPER modifier, so I fixed that as well :).

asteinba commented 6 months ago

Hey @meronz,

I'm using this since the last 6 months and didn't notice any issues. Can we merge this?

meronz commented 5 months ago

Sorry for the delay. I merged the PR and I'll do some testing and push the release to EGO today.