search

GnomeSnapExtensions / gSnap

Gnome-shell extension that allows you to move windows into specific regions similiar to FancyZones on windows.
https://extensions.gnome.org/extension/4442/gsnap/
Other
166 stars 23 forks source link

Add support for GNOME 46 #84

Closed gtirloni closed 5 months ago

gtirloni commented 7 months ago

I haven't noticed any issues with GNOME 46 (Fedora 40 Beta).

Resolves #82

perinm commented 6 months ago

Bump! Will also test this upon release of Ubuntu 24.04, but this PR is probably already harmless

0x5461636F commented 6 months ago

I made these same changes and compiled / installed on Fedora 40 (official release) and it's working great.

KylerJohnsonDev commented 6 months ago

I haven't come across any issues with this branch. Looks good to me, too.

perinm commented 5 months ago

LGTM too on Ubuntu 24.04 LTS! image

ShoQue92 commented 5 months ago

Using this change, I have executed the steps as mentioned in DEVELOPING.md. It looks like my version of GNOME is undefined? Using Ubuntu 24.04.

image

image

perinm commented 5 months ago

Probably, here works normally. Did you paste the contents output of the build in the extension folder?

On Mon, May 13, 2024, 16:09 Joerie Brugts @.***> wrote:

Using this change, I have executed the steps as mentioned in DEVELOPING.md, but it still seems to think its for GNOME 45. Am i missing something? Running Ubuntu 24.04.

image.png (view on web) https://github.com/GnomeSnapExtensions/gSnap/assets/72988098/46340823-5b32-4188-9322-424639adb42e

image.png (view on web) https://github.com/GnomeSnapExtensions/gSnap/assets/72988098/eb0a11b4-6129-479a-a920-029ee92c38f4

— Reply to this email directly, view it on GitHub https://github.com/GnomeSnapExtensions/gSnap/pull/84#issuecomment-2108607213, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNN2SPYZ7YIRPZXQYFWD43ZCEFVBAVCNFSM6AAAAABF46DOTCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGYYDOMRRGM . You are receiving this because you commented.Message ID: @.***>

ShoQue92 commented 5 months ago

I asumed the build step would do that for me. I checked the extensions folder and saw files with a simmilar timestamp as in the ./dist folder of where i executed the build command.

Cleared the extensions folder and moved those files over to double check, same result. Im new to building extensions, so bare with me.

nittendev commented 5 months ago

Running on fedora 40. Working great. Also as an aside, this is the best extension ever. I can't live without it.

perinm commented 5 months ago

I asumed the build step would do that for me. I checked the extensions folder and saw files with a simmilar timestamp as in the ./dist folder of where i executed the build command.

Cleared the extensions folder and moved those files over to double check, same result. Im new to building extensions, so bare with me.

@ShoQue92 I just remembered couple things I did that might help you.

  1. I deleted the content on the extension folder and replaced with dist ones.
  2. I made sure the folder was called "gSnap@micahosborne" and was at ".local/share/gnome-shell/extensions/gSnap@micahosborne"
  3. I searched for extensions in Ubuntu applications menu, opened and enabled extensions and gSnap extension.
meronz commented 5 months ago

Sorry for the delay. I merged the PR and I'll do some testing and push the release to EGO today.

meronz commented 5 months ago

I asumed the build step would do that for me. I checked the extensions folder and saw files with a simmilar timestamp as in the ./dist folder of where i executed the build command.

Cleared the extensions folder and moved those files over to double check, same result. Im new to building extensions, so bare with me.

Sometimes it happens that the extension you build is "updated" with the version available on extensions.gnome.org. To avoid any unexpected update, in manifest.json set the version to something like 9999. This way the extension won't be replaces with the currently released version :)