Transfer limit for ETH and token transfers

GnosisEcosystemFund commented 5 years ago

Background

The Gnosis Safe as multi-signature wallet requires all transactions to be signed by a predefined (sub)set of owners. In some use cases, it is desirable that only a single owner or a smaller subset allowed to make transfers up to a certain limit. These will be realized via modules within the Gnosis Safe smart contracts. A simple implementation of a daily limit module can be found here.

Task

Please write a general transfer limit module (or several thereof) for the Gnosis Safe.

Acceptance criteria

The solution is implemented as Gnosis Safe smart contract module in Solidity.
A user can specify the time frame of the transfer limit, i.e. the point in time when it gets reset to 0
- The limit can reset daily or weekly on the beginning of the time frame or be “rolling”, i.e. always consider the exact last 24h or last 7 days.
A user can specify how many owners need to confirm the transfer first. (Minimum: 1, maximum: global confirmation threshold of the Safe - 1)
It is possible to set a transfer limit for ETH and each token separately
It is possible to set a global transfer limit in ETH that considers also token transfers (ETH <> token is converted via a ticker.)
- Please use the DutchX as price oracle
The Safe has the feature to pay for transaction fees with funds from within the contract. The submitter of the transaction gets refunded as part of the transaction (cf. smart contract and docs) The transfer limit module needs to have the same feature.
The user can specify an optional non-owner address that is also authorized to perform transactions up to the transfer limit.
It is possible to set a global transfer limit in fiat currency.
- Please use the DutchX as price oracle (1USD = 1DAI)
All smart contracts have 100% test coverage with solidity-coverage
All public methods have netspecs
Linters are applied (Solium or Solhint)
Readme with setup instructions and explanations for implementation details
All code (Variables, function names, comments) is in English

Payout:

200 GNO Additional GNO can be tipped according to the level of technical implementation

Others

Read our documentation to get started. Contact us via Gitter in case you need support or have questions.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 GNO attached to it as part of the Gnosis fund.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $54,694.37 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 years, 8 months ago. Please review their action plans below:

1) s1na has been approved to start work.

I will try to implement the spec, drawing upon my experience of developing another Gnosis Safe module. 2) phabc has applied to start work _(Funders only: approve worker | reject worker)_.

I believe I have already a good understanding of how the Gnosis Safe works and find most criteria manageable. I would start by building the general payment limit based on token amounts and then add supports for fiat limit via the DutchX platform, which I believe is the main piece that will need to read more about.

Learn more on the Gitcoin Issue Details page.

frankchen07 commented 5 years ago

hello @GnosisEcosystemFund - Frank from Gitcoin here - you have workers waiting for your approval! :)

gitcoinbot commented 5 years ago

@s1na Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@s1na Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] warning (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

s1na commented 5 years ago

Hey @gitcoinbot, yes, I was at devcon and I will be starting to work on this only from now. I'll make a WIP PR in safe-contracts soon.

GnosisEcosystemFund commented 5 years ago

@s1na I snoozed the Gitcoinbot you should have a few days for working on the bounty. great to have you on board, looking forward to your implementation. Feel free to reach out to us if you have more questions.

gitcoinbot commented 5 years ago

@s1na Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@s1na Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

s1na commented 5 years ago

@gitcoinbot Yes, here's the PR :)

spm32 commented 5 years ago

Thanks @s1na!

gitcoinbot commented 5 years ago

@s1na Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

[x] reminder (3 days)
[ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

s1na commented 5 years ago

During this week I will try to address the comments.

MareenG commented 5 years ago

@s1na no worries it was the Gitcoinbot. I will snooze him for a few more days :)

gitcoinbot commented 5 years ago

⚡️ A tip worth 100.00000 GNO (2209.0 USD @ $22.09/GNO) has been granted to @s1na for this issue from @GnosisEcosystemFund. ⚡️

Nice work @s1na! Your tip has automatically been deposited in the ETH address we have on file.

$105915.22 in Funded OSS Work Available at: https://gitcoin.co/explorer
Incentivize contributions to your repo: Send a Tip or Fund a PR
No Email? Get help on the Gitcoin Slack

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

GnosisEcosystemFund tipped 100.0000 GNO worth 2209.0 USD to s1na.

Learn more on the Gitcoin Issue Details page
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$105,915.22 more funded OSS Work available on the Gitcoin Issue Explorer

GnosisEcosystemFund / Gnosis-Bounties-