search

GnoxNahte / obsidian-auto-embed

Obsidian plugin to embed websites using simple markdown instead of iframe
MIT License
18 stars 0 forks source link

[FEATURE]: Embed SoundCloud songs #3

Closed Rikiub closed 3 months ago

Rikiub commented 3 months ago

You can see a example in Iframely

image

GnoxNahte commented 3 months ago

Hey I was looking through SoundCloud's docs and found these options. Was thinking of putting "Auto Play" and maybe "Single Active" in the plugin settings. Keeping it to 2 options to keep it simple. Do you think its good? Do you want any other options?

GnoxNahte commented 3 months ago

Actually after thinking about it, I think I won't add Auto play and Single Active as options. I don't see why Auto Play should be enabled. It feels like it'll be quite messy as every time you open the note, it'll play the song. Unless you want to have specific notes play their own songs when you open it?

Just comment here if you feel like you want the setting to be there. I'll just disable Auto Play from the start and won't set any value to Single Active.

GnoxNahte commented 3 months ago

Hey, I added it into the latest version - 1.1.1. If you face any problems with it or have any feedback (including the stuff I mentioned above), you can reopen the issue.

Rikiub commented 3 months ago

Actually after thinking about it, I think I won't add Auto play and Single Active as options. I don't see why Auto Play should be enabled. It feels like it'll be quite messy as every time you open the note, it'll play the song. Unless you want to have specific notes play their own songs when you open it?

Just comment here if you feel like you want the setting to be there. I'll just disable Auto Play from the start and won't set any value to Single Active.

In my opinion, I prefer don't have auto play enabled because I wouldn't like heard music each time that I open a note (xD).

But wow, you implement this so fast! Thanks so much!

GnoxNahte commented 3 months ago

Great! Autoplay is disabled for now.

Haha welcome! It's the weekend and I'm free :)