search

Gnurfos / transvoxel_rs

Rust implementation of the Transvoxel algorithm
Apache License 2.0
24 stars 6 forks source link

Update Bevy to 0.11 #6

Closed nilaysavant closed 1 year ago

nilaysavant commented 1 year ago

Hey. Firstly, thank you for this library!

I just got started with voxels, and wanted to play around. Found it easy to just update the Bevy version to 0.11 with the following changes:

The examples seems to be running fine and all tests are passing.

Hope this helps!

Gnurfos commented 1 year ago

Hi, thank you for the PR. Running the examples fail on my computer at the moment:

cargo run --example single_block Finished dev [optimized + debuginfo] target(s) in 0.13s warning: the following packages contain code that will be rejected by a future version of Rust: rustc-serialize v0.3.24 note: to see what the problems were, use the option --future-incompat-report, or run cargo report future-incompatibilities --id 1 Running target/debug/examples/single_block 2023-09-15T09:13:15.437051Z INFO bevy_winit::system: Creating new window "App" (0v0) 2023-09-15T09:13:15.437182Z INFO winit::platform_impl::platform::x11::window: Guessed window scale factor: 1
thread 'main' panicked at 'called Result::unwrap() on an Err value: Syntax(

regex parse error:
(\/\/|\/\*|\*\/)
^^
error: unrecognized escape sequence

)', /home/seb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/comment_strip_iter.rs:6:67 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

(I did "cargo clean" too, although this shouldn't be necessary) I don't have a lot of time right now to dig deeper, so if this rings a bell to you, you can try. Otherwise I'll get back to it some time later.

nilaysavant commented 1 year ago

Hmm. So naga_oil is a dependency used by bevy. I can see that it is using the version 0.8.2 which is same as the one in my lock file. But very likely the regex crate it depends on is already updated with a fix.

It might just be that your lockfile Cargo.lock needs an update:

This should regenerate the lockfile with newer updates (minor versions) of crates and this issue might resolve itself. Since we're not tracking the Cargo.lock there should be no changes to source code needed here.

Gnurfos commented 1 year ago

That did the trick. I think someone lied to semver somewhere, and must have broken a lot of builds ... I published version 1.1.0 with your changes. Thanks for the help!