search

GoAdminGroup / go-admin

A golang framework helps gopher to build a data visualization and admin panel in ten minutes
https://www.go-admin.com
Apache License 2.0
8.11k stars 1.32k forks source link

[Proposal] Potential code quality issues found #306

Open ghost opened 4 years ago

ghost commented 4 years ago

I forked this repo a while ago and ran a DeepSource analysis on it. DeepSource found a variety of different issues categorized based on their types and severity which you can view here.

Brief description - Anti-Patterns: 125 Bug Risks: 45 Performance issues: 20 Security Issues: 234

You can find a detailed description and fixes for some of them here.

Please let me know what issues you'd like to focus on fixing and I'd be happy to take a look into it. Also, you can choose to hide certain types of issues too (if you wish to ignore them or you believe it is a false positive). I'd also be happy to send a patch with the DeepSource configuration file with the required fixes.

You can find the required configuration file for DeepSource here.

chenhg5 commented 4 years ago

@chsatyap Thanks for the feedback.

gerrywp commented 4 years ago

这个是什么检测工具，这个先进啊

ghost commented 4 years ago

@gerrywp It's a static analyzer tool. I'd be happy to point you to further resources if required!