GoCarrot / teak-android

Carrot SDK for Android
Apache License 2.0
0 stars 0 forks source link

checkAttributionForRewardAndPostEvents needs to also handle 'notifications' #80

Closed AlexSc closed 3 years ago

AlexSc commented 3 years ago

Currently checkAttributionForRewardAndPostEvents assumes that it will only ever handle a link, with a teak_rewardlink_name attribute. This is not the case, however, as emails are "notifications" which come in through the link path. The iOS SDK handles this, see https://github.com/GoCarrot/teak-ios/blob/b0be033ff84811dfbbc2d3a544842c493f2bf1b6/Teak/TeakReward.m#L92

While I think it makes more sense to handle this as part of standardizing launch callbacks in terms of development flow, the fact of the matter is that it is a bug and we should have a fix in 4.1 at the latest.