search

GoEddie / DeploymentContributorFilterer

MIT License
70 stars 35 forks source link

Fix TableColumnFilterRule (KeepTableColumn filter). #22

Closed PrefixAM closed 3 years ago

PrefixAM commented 4 years ago

There is a bug in TableColumnFilterRule.cs ( SqlPackageFilter=KeepTableColumns(Employees) ). When generated change script starts from PredicateSetStatement (i.e. SET ANSI_NULLS ) instead of AlterTableDropTableElementStatement (as the current code expects), the filter does not remove DROP COLUMN statements. As a result, the columns getting dropped when the expected behavior is that they will remain unmodified. TableColumnFilterRule

GoEddie commented 3 years ago

nice, thanks - don't often visit the pr page here sorry!