search

GoEddie / SQLCover

Apache License 2.0
63 stars 53 forks source link

Feature Requests #34

Open GoEddie opened 5 years ago

GoEddie commented 5 years ago

If you have any feature requests, add a comment here with as much detail - when I work on the next version then I will consider them.

If you want to see a feature implemented it, add a comment with the feature number and a +1

GoEddie commented 5 years ago

Request #1: Cover inline table valued functions

Statements inside inline table valued functions are not currently covered, the sp_statement_completed event doesn't include inline tvf's but we do get a intent-shared transaction lock so we could include those in the trace and show whether an inline tvf has at least been called. They can't contain branches in so they would either be 0% or 100% covered.

Possible issues to consider:

Do different isolation modes change the lock types? -Can we filter to just inline tvf's? -The current trace system wouldn't be able to cope with adding lock aquired's in, more work on the perf of that side of things would be required -Do we always get a lock for it?

This was copied from: https://github.com/GoEddie/SQLCover/issues/30

GoEddie commented 5 years ago

Request #2: Corbertura output files support

done - included in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

GoEddie commented 5 years ago

Request #3: html output: navigation buttons to go to top of page

done - included in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

GoEddie commented 5 years ago

Request #4: Sql 2019

GoEddie commented 5 years ago

Request: #5: Sql on linux support (might just be testing)

GoEddie commented 5 years ago

Request #6: Configure timeout

done - in 0.5.0:

https://github.com/GoEddie/SQLCover/releases/tag/0.5.0

Athi2019 commented 5 years ago

Do we have a resolution for Request https://github.com/GoEddie/SQLCover/issues/5 please?

GoEddie commented 5 years ago

@Athi2019 no sorry, I haven't tried covering t-sql on a sql on linux instance - if you have and it doesn't work it would be great if you can add any details of exceptions etc.

Athi2019 commented 5 years ago

@GoEddie I am trying to cover t-sql on a windows sql instance . Please refer this link for the details: https://forum.red-gate.com/discussion/85990/incorrect-sql-test-code-coverage#latest

GoEddie commented 5 years ago

Hi @athi2019 sorry I misunderstood, I see now :)

The issue you have is a few days work and I don’t have the capacity at the moment for that amount of OSS work.

If it is important to you and you have a budget I would be happy to discuss sponsorship to get it working for you, if you would like to pursue this please reach out to me ed@agilesql.co.uk

Ed

persistence911 commented 4 years ago

Please can you add an azure-pipeline examples to this repo.. I am using with Azure and I am not sure I am doing it right because report generator shows files missing when I drill down.

lowlydba commented 4 years ago

Request: Output report files in UTF-8 by default.

I had issues uploading the OpenCover XML to sites like https://codecov.io since it wasn't in UTF-8. I'm now manually converting before uploading, but it would be nice if that was default or an option. A low lift would be to include this in the example .ps1 file as well.

lastlink commented 4 years ago

@persistence911 there is now a github action that works, also see my open sourced project https://dev.azure.com/funktechno/_git/dotnet%20ci%20pipelines?path=%2Fazure-pipelines.yml for running a sql server instance in an azure devops pipeline