search

GoIncremental / negroni-oauth2

Apache License 2.0
71 stars 25 forks source link

Fix compatibility with golang/oauth2 (cf: a568078) #8

Closed minjatJ closed 9 years ago

minjatJ commented 9 years ago

Fix compatibilities with commit a568078 from golang/oauth2 repository.

To me NewOauth2Provider looks clearer with 'authUrl' and 'tokenUrl' as args instead of being part of an option array (it was also easier to use). Let me know if you want it back an option array.

Bochenski commented 9 years ago

I went with option array from a previous PR from @denizeren as it's matched martini-contrib/oauth2. But I agree with you - it's nicer this way I think. Struggling to keep up with all the changes to golang/oauth2 so thanks for the contribution. I'll update the tests then merge.