search

GoSecure / malboxes

Builds malware analysis Windows VMs so that you don't have to.
GNU General Public License v3.0
1.03k stars 134 forks source link

use PACKER_CACHE_DIR env var if already set #100

Closed Wenzel closed 6 years ago

Wenzel commented 6 years ago

This PR checks for the value of PACKER_CACHE_DIR first, and then defaults to DIRS.user_cache_dir.

Solves https://github.com/GoSecure/malboxes/issues/99

You can review it, i'm testing it right now.

Wenzel commented 6 years ago

It works :+1:

Svieg commented 6 years ago

Build failed because Python3.3 doesn't support enum and a dep of pylint uses it. I'll try your fix tomorrow and update this PR.

obilodeau commented 6 years ago

Resubmitted the job. Hopefully, it got fixed by upstream in the meantime.

obilodeau commented 6 years ago

It didn't fix it.

After some googling, I found out that pylint no longer supports Python 3.3. Python 3.3 has been end of life in 2017 and even Ubuntu 14.04 runs with Python 3.4 by default.

I'm going to fix this in a PR then resubmit the job here.

Edit: added the link

obilodeau commented 6 years ago

Merged. I ignored failure related to Python 3.3 since it was fixed with #101.