GoSecure / pyrdp

RDP monster-in-the-middle (mitm) and library for Python with the ability to watch connections live or after the fact
https://www.gosecure.net/blog/2020/10/20/announcing-pyrdp-1/
GNU General Public License v3.0
1.5k stars 242 forks source link

Dropping support of pre-built docker images for linux/arm/v7 #388

Closed obilodeau closed 2 years ago

obilodeau commented 2 years ago

Cryptography requires rustc and cargo in order to build since the beginning of last year. We carried a workaround when we implemented ARM builds for docker in 724bd5ef1a94.

When I pushed the dependency updates, our ARMv7 (aka armhf) docker builds stopped working: https://github.com/GoSecure/pyrdp/runs/4861875591?check_suite_focus=true.

After investigation, the cryptography project seemed to have stepped up and is providing prebuilt cryptography packages for a lot of platforms but not linux/arm/v7 and they have no intention of doing so: https://github.com/pyca/cryptography/issues/6286.

I spent one hour trying to build the package inside the compile container with rust and cargo installed but it would fail for various reasons including obscure linux or QEMU ones. Thinking about how many linux/arm/v7 users we might have out there I don't think it's worth the effort.

If someone reads this, know that you can always install pyrdp from source and it should work since the issues were around cargo having problems with the docker+QEMU emulation.

We still build docker images for ARM64 (aka aarch64).