replay file closing - Githubissues

GoSecure / pyrdp

RDP monster-in-the-middle (mitm) and library for Python with the ability to watch connections live or after the fact

https://www.gosecure.net/blog/2020/10/20/announcing-pyrdp-1/

GNU General Public License v3.0

1.5k stars 242 forks source link

replay file closing #431

Closed gninjamaster closed 9 months ago

gninjamaster commented 1 year ago

Trying to find out where the replay file is close when the client logout or disconnect from the RDP session. TCPMITM doesn't seem to call it during the disconnect event. When I check with the lsof, the file still open. Not sure if this intentional?

obilodeau commented 1 year ago

No, it could be a bug.

obilodeau commented 10 months ago

I tested locally and verified with lsof and I can't reproduce the issue.

I also checked environments that are hammered with scanners and actual connections and I didn't find dangling file descriptors.

We will need more information to attempt to reproduce.

Python version
Twisted version
Operating system (Windows WSL or Linux?)
PyRDP version (or is it master?)

I'm on Linux with pyrdp master, running python 3.11.6 and twisted 22.10.0.

Thanks!

obilodeau commented 9 months ago

Please re-open when you are ready to investigate.