GoSecure / pyrdp

RDP monster-in-the-middle (mitm) and library for Python with the ability to watch connections live or after the fact
https://www.gosecure.net/blog/2020/10/20/announcing-pyrdp-1/
GNU General Public License v3.0
1.5k stars 242 forks source link

pyrdp-covert Attribute Error: 'str' object has no attribute 'ip' #457

Closed MundaneTracing closed 10 months ago

MundaneTracing commented 10 months ago

pyrdp-covert appears to see the source and dest.

┌──(venv)─(parallels㉿kali-linux-2022-2)-[~/Downloads] └─$ pyrdp-convert rdp-replay.pcap -l [*] Analyzing PCAP 'rdp-replay.pcap' ...

But I get the below error on my kali vm. I get the same error with pyrdp installed on a Windows 10 machine as well. Followed the instructions for the layer 7 and no luck. I did not see a comparable previous issue upon searching.

Thoughts??

┌──(venv)─(parallels㉿kali-linux-2022-2)-[~/Downloads] └─$ pyrdp-convert rdp-replay.pcap --src 10.0.0.2 -f replay -o rdp-replay [*] Analyzing PCAP 'rdp-replay.pcap' ... Traceback (most recent call last): File "/home/parallels/Pentest/tools/pyrdp/venv/bin/pyrdp-convert", line 8, in sys.exit(main()) ^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/bin/convert.py", line 99, in main exitCode = converter.process() ^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 41, in process streams = self.listSessions() ^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 78, in listSessions if self.checkSrcExcluded(client) or self.checkDstExcluded(server): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 35, in checkSrcExcluded return len(self.srcFilter) > 0 and src not in self.srcFilter ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/utils.py", line 62, in eq if self.ip == other.ip and self.port == other.port: ^^^^^^^^ AttributeError: 'str' object has no attribute 'ip'

┌──(venv)─(parallels㉿kali-linux-2022-2)-[~/Downloads] └─$ pyrdp-convert rdp-replay.pcap --src 10.0.0.2 -f replay -o rdp-replay

┌──(venv)─(parallels㉿kali-linux-2022-2)-[~/Downloads] └─$ pyrdp-convert --src 10.0.0.2 --dst 10.1.1.1 -f replay -o rdp-replay rdp-replay.pcap [*] Analyzing PCAP 'rdp-replay.pcap' ... Traceback (most recent call last): File "/home/parallels/Pentest/tools/pyrdp/venv/bin/pyrdp-convert", line 8, in sys.exit(main()) ^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/bin/convert.py", line 99, in main exitCode = converter.process() ^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 41, in process streams = self.listSessions() ^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 78, in listSessions if self.checkSrcExcluded(client) or self.checkDstExcluded(server): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/PCAPConverter.py", line 35, in checkSrcExcluded return len(self.srcFilter) > 0 and src not in self.srcFilter ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/parallels/Pentest/tools/pyrdp/pyrdp/convert/utils.py", line 62, in eq if self.ip == other.ip and self.port == other.port: ^^^^^^^^ AttributeError: 'str' object has no attribute 'ip'

MundaneTracing commented 10 months ago

rdp-replay.pcap.zip

Here is the pcap I'm working with.

MundaneTracing commented 10 months ago

Fixed issue by exporting "Captured" traffic and not Displayed traffic. Evidently I was missing some key data.

obilodeau commented 9 months ago

Glad you figured it out.