GoSecure / pyrdp

RDP monster-in-the-middle (mitm) and library for Python with the ability to watch connections live or after the fact
https://www.gosecure.net/blog/2020/10/20/announcing-pyrdp-1/
GNU General Public License v3.0
1.5k stars 242 forks source link

pyrdp-convert crash #463

Closed PLTorrent closed 9 months ago

PLTorrent commented 9 months ago

pyrdp-convert crashes when I try to convert a pcap rdp session. I am using the latest docker image.

pyrdp@33df43f0ab6a:~$ pyrdp-convert --list-only rdp.pcap
[*] Analyzing PCAP 'rdp.pcap' ...
    - 10.0.0.2:55510 -> 10.1.1.1:3389 : plaintext
pyrdp@33df43f0ab6a:~$ pyrdp-convert --src 10.1.1.1 -o ~/ rdp.pcap
[*] Analyzing PCAP 'rdp.pcap' ...
Traceback (most recent call last):
  File "/opt/venv/bin/pyrdp-convert", line 8, in <module>
    sys.exit(main())
  File "/opt/venv/lib/python3.10/site-packages/pyrdp/bin/convert.py", line 99, in main
    exitCode = converter.process()
  File "/opt/venv/lib/python3.10/site-packages/pyrdp/convert/PCAPConverter.py", line 41, in process
    streams = self.listSessions()
  File "/opt/venv/lib/python3.10/site-packages/pyrdp/convert/PCAPConverter.py", line 78, in listSessions
    if self.checkSrcExcluded(client) or self.checkDstExcluded(server):
  File "/opt/venv/lib/python3.10/site-packages/pyrdp/convert/PCAPConverter.py", line 35, in checkSrcExcluded
    return len(self.srcFilter) > 0 and src not in self.srcFilter
  File "/opt/venv/lib/python3.10/site-packages/pyrdp/convert/utils.py", line 62, in __eq__
    if self.ip == other.ip and self.port == other.port:
AttributeError: 'str' object has no attribute 'ip'
obilodeau commented 9 months ago

Couple of questions:

Thanks

obilodeau commented 9 months ago

Feel free to re-open the issue when you can answer the questions.